追求代码质量: 测试 Struts 遗留的应用程序

public ActionForward execute(ActionMapping mapping, ActionForm aForm,
            HttpServletRequest req, HttpServletResponse res) throws Exception {
            try{
            String newPassword = ((ChangePasswordForm)aForm).getNewPassword1();
            String username = ((ChangePasswordForm)aForm).getUsername();
            IUser user = DataAccessUtils.getDaos().getUserDao().findUserByUsername(username);
            user.digestAndSetPassword(newPassword);
            DataAccessUtils.getDaos().getUserDao().saveUser(user);
            }catch(Throwable thr){
            return findFailure(mapping, aForm, req, res);
            }
            return findSuccess(mapping, aForm, req, res);
            }
            

if((newPassword1 == null) || (newPassword1.length() < 1)) {
            errors.add("newPassword1",
            new ActionError("error.changePassword.newPassword1Required"));
            }
            if((newPassword2 == null) || (newPassword2.length() < 1)) {
            errors.add("newPassword2",
            new ActionError("error.changePassword.newPassword2Required"));
            }
            if((newPassword1 != null) && (newPassword2 != null)) {
            if(!newPassword1.equals(newPassword2)) {
            errors.add(ActionErrors.GLOBAL_ERROR,
            new ActionError("error.changePassword.passwordsDontMatch"));
            }
            }
            

root/
            src/
            conf/
            java/
            webapp/
            images/
            jsp/
            WEB-INF/
            test/
            

public void setUp() throws Exception {
            try {
            super.setUp();
            this.setContextDirectory(new File("src/webapp/"));
            this.setServletConfigFile("src/webapp/WEB-INF/web.xml");
            this.setConfigFile(
            this.getSession().getServletContext()
            .getRealPath("WEB-INF/struts-config.xml"));
            }catch (Exception e) {
            fail("Unable to setup test");
            }
            }
            

<action path="/changePasswordSubmit"
            type="com.acme.ccb.action.ChangePasswordAction"
            name="changePasswordForm" scope="request"
            input="/jsp/admin/changepassword.jsp">
            <forward name="success" path="/viewUsers.do"
            redirect="true" contextRelative="false" />
            </action>
            

public void testExecute() throws Exception{
            setRequestPathInfo("/changePasswordSubmit");
            addRequestParameter("username","jane");
            addRequestParameter("currentPassword","admin");
            addRequestParameter("newPassword1","meme");
            addRequestParameter("newPassword2","meme");
            actionPerform();
            verifyForward("success");
            }
            

<?xml version='1.0' encoding='WINDOWS-1252'?>
            <dataset>
            <!-- user with password admin -->
            <user username="jane"
            password="d033e22ae348aeb5660fc2140aec35850c4da997"
            name="Jane Admin"
            date_created="2003-8-14 10:10:10"
            email="jane@elsewhere.org"/>
            <user_role username="jane" rolename="ADMIN"/>
            </dataset>
            

private void executeSetUpOperation() throws Exception{
            final IDatabaseConnection connection = this.getConnection();
            try{
            DatabaseOperation.CLEAN_INSERT.execute(connection, this.getDataSet());
            }finally{
            connection.close();
            }
            }
            private IDataSet getDataSet() throws IOException, DataSetException {
            return new FlatXmlDataSet(new File("test/conf/dbunit-user-seed.xml"));
            }
            private IDatabaseConnection getConnection() throws ClassNotFoundException, SQLException {
            final Class driverClass = Class.forName("org.gjt.mm.mysql.Driver");
            final Connection jdbcConnection = DriverManager.
            getConnection("jdbc:mysql://localhost/ccb01",
            "9043", "43xli");
            return new DatabaseConnection(jdbcConnection);
            }
            

<?xml version='1.0' encoding='WINDOWS-1252'?>
            <dataset>
            <user username="jane"
            password="58117e24e4d0b8a958146c9eaa28336184f4d491"/>
            </dataset>
            

private void verifyPassword(String fileName) throws Exception{
            final IDataSet expectedDataSet = new FlatXmlDataSet(
            new File(fileName));
            final ITable defJoinData = this.getConnection().
            createQueryTable("TestResult",
            "select user.username, user.password " +
            "from user where user.username=\"jane\"");
            final ITable defTable = expectedDataSet.getTable("user");
            Assertion.assertEquals(defJoinData, defTable);
            }
            

package test.com.acme.ccb.action;
            import java.io.File;
            import java.io.IOException;
            import java.sql.Connection;
            import java.sql.DriverManager;
            import java.sql.SQLException;
            import org.dbunit.Assertion;
            import org.dbunit.database.DatabaseConnection;
            import org.dbunit.database.IDatabaseConnection;
            import org.dbunit.dataset.DataSetException;
            import org.dbunit.dataset.IDataSet;
            import org.dbunit.dataset.ITable;
            import org.dbunit.dataset.xml.FlatXmlDataSet;
            import org.dbunit.operation.DatabaseOperation;
            import servletunit.struts.MockStrutsTestCase;
            public class ChangePasswordActionTest extends MockStrutsTestCase {
            public ChangePasswordActionTest(String arg0) {
            super(arg0);
            }
            public void setUp() throws Exception {
            try {
            super.setUp();
            this.executeSetUpOperation();
            this.setContextDirectory(new File("src/webapp/"));
            this.setServletConfigFile("src/webapp/WEB-INF/web.xml");
            this.setConfigFile(
            this.getSession().getServletContext()
            .getRealPath("WEB-INF/struts-config.xml"));
            } catch (Exception e) {
            fail("Unable to setup test");
            }
            }
            public void testExecute() throws Exception{
            setRequestPathInfo("/changePasswordSubmit");
            addRequestParameter("username","jane");
            addRequestParameter("currentPassword","admin");
            addRequestParameter("newPassword1","meme");
            addRequestParameter("newPassword2","meme");
            actionPerform();
            verifyForward("success");
            verifyPassword("test/conf/dbunit-expect-user.xml");
            }
            private void executeSetUpOperation() throws Exception{
            final IDatabaseConnection connection = this.getConnection();
            try{
            DatabaseOperation.CLEAN_INSERT.execute(connection, this.getDataSet());
            }finally{
            connection.close();
            }
            }
            private IDataSet getDataSet() throws IOException, DataSetException {
            return new FlatXmlDataSet(new File("test/conf/dbunit-user-seed.xml"));
            }
            private IDatabaseConnection getConnection() throws ClassNotFoundException, SQLException {
            final Class driverClass = Class.forName("org.gjt.mm.mysql.Driver");
            final Connection jdbcConnection = DriverManager.
            getConnection("jdbc:mysql://localhost/ccb01",
            "9043", "43xli");
            return new DatabaseConnection(jdbcConnection);
            }
            private void verifyPassword(String fileName) throws Exception{
            final IDataSet expectedDataSet = new FlatXmlDataSet(
            new File(fileName));
            final ITable defJoinData = this.getConnection().
            createQueryTable("TestResult",
            "select user.username, user.password " +
            "from user where user.username=\"jane\"");
            final ITable defTable = expectedDataSet.getTable("user");
            Assertion.assertEquals(defJoinData, defTable);
            }
            }
            

public void testExecuteWithErrors() throws Exception{
            setRequestPathInfo("/changePasswordSubmit");
            addRequestParameter("username","jane");
            addRequestParameter("currentPassword","admin");
            addRequestParameter("newPassword1","meme");
            addRequestParameter("newPassword2","emem");
            actionPerform();
            verifyActionErrors(
            new String[]{"error.changePassword.passwordsDontMatch"});
            verifyPassword("test/conf/dbunit-expect-user-same.xml");
            }